Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-634755 fix typing_extensions version pin #1208

Merged
merged 4 commits into from
Jul 26, 2022
Merged

SNOW-634755 fix typing_extensions version pin #1208

merged 4 commits into from
Jul 26, 2022

Conversation

sfc-gh-mkeller
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-634755: ImportError: cannot import name 'NamedTuple' from 'typing_extensions' #1206

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    In this PR I add the missing lower version pin to our new dependency from SNOW-574657 in-memory cache impementation #1195

@sfc-gh-kdama sfc-gh-kdama merged commit 253b2ce into main Jul 26, 2022
@sfc-gh-kdama sfc-gh-kdama deleted the mkeller/SNOW-634755-add_minimum_version_pin branch July 26, 2022 21:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan approved these changes

@sfc-gh-jdu sfc-gh-jdu sfc-gh-jdu approved these changes

@sfc-gh-kwagner sfc-gh-kwagner Awaiting requested review from sfc-gh-kwagner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-634755: ImportError: cannot import name 'NamedTuple' from 'typing_extensions'
4 participants
@sfc-gh-mkeller @sfc-gh-jdu @sfc-gh-sfan @sfc-gh-kdama