Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-584369 get_results_from_sfqid missing errno #1156

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

sfc-gh-mkeller
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-584369

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Errors raised when running get_results_from_sfqid are missing errno numbers. In addition I found that we had no nice error messages when a query is not found by the same method. So I added error checking and nicer error message when this happens.

@sfc-gh-mkeller sfc-gh-mkeller self-assigned this May 27, 2022
@sfc-gh-mkeller sfc-gh-mkeller changed the title SNOW-584369 fix bug and modify a test to verify correctness SNOW-584369 get_results_from_sfqid missing errno May 27, 2022
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-584369-errno_missing_async_query branch from 61edcda to 0bc653f Compare May 27, 2022 23:07
@codecov-commenter
Copy link

Codecov Report

Merging #1156 (0bc653f) into main (b132ab1) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 0bc653f differs from pull request most recent head d113742. Consider uploading reports for the commit d113742 to get more accurate results

@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
- Coverage   84.94%   84.85%   -0.10%     
==========================================
  Files          57       57              
  Lines        7831     7829       -2     
  Branches     1265     1264       -1     
==========================================
- Hits         6652     6643       -9     
- Misses        881      888       +7     
  Partials      298      298              
Impacted Files Coverage Δ
src/snowflake/connector/connection.py 92.61% <100.00%> (+0.13%) ⬆️
src/snowflake/connector/network.py 81.32% <0.00%> (-1.66%) ⬇️
src/snowflake/connector/ocsp_snowflake.py 71.30% <0.00%> (-0.56%) ⬇️
src/snowflake/connector/errors.py 89.89% <0.00%> (-0.54%) ⬇️
src/snowflake/connector/telemetry_oob.py 74.80% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b132ab1...d113742. Read the comment docs.

DESCRIPTION.md Outdated Show resolved Hide resolved
src/snowflake/connector/connection.py Outdated Show resolved Hide resolved
@sfc-gh-mkeller sfc-gh-mkeller merged commit 2d78cb0 into main Jun 1, 2022
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/SNOW-584369-errno_missing_async_query branch June 1, 2022 21:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants