-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-584369 get_results_from_sfqid missing errno #1156
SNOW-584369 get_results_from_sfqid missing errno #1156
Conversation
61edcda
to
0bc653f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
- Coverage 84.94% 84.85% -0.10%
==========================================
Files 57 57
Lines 7831 7829 -2
Branches 1265 1264 -1
==========================================
- Hits 6652 6643 -9
- Misses 881 888 +7
Partials 298 298
Continue to review full report at Codecov.
|
Co-authored-by: Yijun Xie <[email protected]>
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-584369
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Errors raised when running
get_results_from_sfqid
are missingerrno
numbers. In addition I found that we had no nice error messages when a query is not found by the same method. So I added error checking and nicer error message when this happens.