Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix skip logic #1153

Merged
merged 1 commit into from
May 26, 2022
Merged

fix skip logic #1153

merged 1 commit into from
May 26, 2022

Conversation

sfc-gh-mkeller
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller commented May 25, 2022 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    A recently added test exposed an issue where the internal test tag didn't work as expected. It turns out that Our Mac and Windows tests also use public Snowflake deployments, so these runs should also skip running internal tests.
    Now correct runs:

@sfc-gh-mkeller sfc-gh-mkeller self-assigned this May 25, 2022
sfc-gh-kdama
sfc-gh-kdama approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@sfc-gh-kdama sfc-gh-kdama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfc-gh-mkeller sfc-gh-mkeller merged commit 76dbb00 into main May 26, 2022
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/fix_test_skipping branch May 26, 2022 16:34
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-kdama sfc-gh-kdama sfc-gh-kdama approved these changes

@sfc-gh-kwagner sfc-gh-kwagner Awaiting requested review from sfc-gh-kwagner

Assignees

@sfc-gh-mkeller sfc-gh-mkeller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mkeller @sfc-gh-kdama