Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-285535: Implement callproc #1143

Merged
merged 6 commits into from
May 23, 2022
Merged

Conversation

sfc-gh-aling
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-285535: Implement callproc

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.
    The issue origins from snowflake-sqlalchemy repo: SNOW-285535: Implement callproc snowflake-sqlalchemy#216.
    To meet users needs, add callproc support to SnowflakeCursor as per pep249: https://peps.python.org/pep-0249/#callproc

@github-actions
Copy link

github-actions bot commented May 17, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-aling
Copy link
Collaborator Author

sfc-gh-aling commented May 17, 2022

I have read the CLA Document and I hereby sign the CLA

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #1143 (615d5b9) into main (68d2029) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
- Coverage   84.69%   84.65%   -0.04%     
==========================================
  Files          57       57              
  Lines        7820     7826       +6     
  Branches     1263     1264       +1     
==========================================
+ Hits         6623     6625       +2     
- Misses        895      899       +4     
  Partials      302      302              
Impacted Files Coverage Δ
src/snowflake/connector/cursor.py 93.72% <100.00%> (+0.05%) ⬆️
src/snowflake/connector/pandas_tools.py 82.02% <100.00%> (+0.20%) ⬆️
src/snowflake/connector/telemetry_oob.py 72.48% <0.00%> (-1.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d2029...615d5b9. Read the comment docs.

@sfc-gh-aling
Copy link
Collaborator Author

sfc-gh-aling commented May 17, 2022

@sfc-gh-mkeller I saw Build and Test / Old Driver Test linux-3.7-aws (pull_request) is failing as it's testing against the v1.9.1 connector.

v1 connector questions:

  • Is the v1 deprecated completely? do we still want/need to keep supporting v1?
  • if we want to keep supporting v1, then to what extent shall we support, only for bug fixing or new features as well?

misc questions:

  • should I tick "I am adding a new automated test(s) to verify correctness of my new code"?
  • changelog, version bump, release notes conventions

DESCRIPTION.md Outdated Show resolved Hide resolved
src/snowflake/connector/cursor.py Outdated Show resolved Hide resolved
src/snowflake/connector/version.py Outdated Show resolved Hide resolved
test/integ/test_cursor.py Outdated Show resolved Hide resolved
test/integ/test_cursor.py Outdated Show resolved Hide resolved
test/integ/test_cursor.py Outdated Show resolved Hide resolved
test/integ/test_cursor.py Outdated Show resolved Hide resolved
test/integ/test_cursor.py Outdated Show resolved Hide resolved
test/integ/test_dbapi.py Outdated Show resolved Hide resolved
test/integ/test_dbapi.py Outdated Show resolved Hide resolved
@sfc-gh-aling sfc-gh-aling force-pushed the SNOW-285535-implement-callproc branch from caf99b4 to 7652923 Compare May 23, 2022 20:42
@sfc-gh-aling sfc-gh-aling merged commit 8f2a2ab into main May 23, 2022
@sfc-gh-aling sfc-gh-aling deleted the SNOW-285535-implement-callproc branch May 23, 2022 22:34
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2022
@sfc-gh-aling sfc-gh-aling restored the SNOW-285535-implement-callproc branch May 23, 2022 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants