Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-584166: Fix the error message when pandas is not installed #1113

Merged
merged 1 commit into from
May 3, 2022

Conversation

sfc-gh-jdu
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-584166

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Our optional dependency is pandas but the error message shows pyarrow. This PR fixes this error message.

@sfc-gh-jdu sfc-gh-jdu requested a review from a team April 29, 2022 22:34
@github-actions
Copy link

github-actions bot commented Apr 29, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-jdu
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@sfc-gh-sfan sfc-gh-sfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1113 (9b41245) into main (0ddd967) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
- Coverage   84.74%   84.66%   -0.08%     
==========================================
  Files          57       57              
  Lines        7805     7805              
  Branches     1259     1259              
==========================================
- Hits         6614     6608       -6     
- Misses        890      895       +5     
- Partials      301      302       +1     
Impacted Files Coverage Δ
src/snowflake/connector/cursor.py 93.67% <ø> (ø)
src/snowflake/connector/result_batch.py 92.41% <ø> (ø)
src/snowflake/connector/ocsp_asn1crypto.py 77.77% <0.00%> (-1.34%) ⬇️
src/snowflake/connector/ocsp_snowflake.py 71.30% <0.00%> (-0.23%) ⬇️
src/snowflake/connector/connection.py 92.44% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ddd967...9b41245. Read the comment docs.

@sfc-gh-mkeller
Copy link
Collaborator

recheck

@sfc-gh-jdu sfc-gh-jdu merged commit 37443fb into main May 3, 2022
@sfc-gh-jdu sfc-gh-jdu deleted the jdu-SNOW-584166-fix-error-message-pandas branch May 3, 2022 20:17
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants