Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-581651 Support pandas < 1.5.0 #1098

Merged
merged 1 commit into from
Apr 25, 2022
Merged

SNOW-581651 Support pandas < 1.5.0 #1098

merged 1 commit into from
Apr 25, 2022

Conversation

arieleizenberg
Copy link
Contributor

@arieleizenberg arieleizenberg commented Apr 22, 2022 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes Update pandas requirement from <1.4.0,>=1.0.0 to >=1.0.0,<1.5.0 #1036

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

Modified setup.py line for pandas, reran unit-tests.

@github-actions
Copy link

github-actions bot commented Apr 22, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@arieleizenberg
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-mkeller sfc-gh-mkeller mentioned this pull request Apr 25, 2022
Closed
@sfc-gh-mkeller sfc-gh-mkeller changed the title Support pandas < 1.5.0 SNOW-581651 Support pandas < 1.5.0 Apr 25, 2022
@sfc-gh-mkeller sfc-gh-mkeller merged commit 36c0941 into snowflakedb:main Apr 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arieleizenberg @sfc-gh-mkeller