Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-572600 switch to new build process #1091

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Conversation

sfc-gh-mkeller
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller commented Apr 12, 2022

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-572600

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Switching to cibuildwheel to build wheels with. This switch allows us to build ARM wheels for both Linux and MacOS.

@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/wheel_build branch 6 times, most recently from a31561b to c27f940 Compare April 13, 2022 00:03
@codecov-commenter
Copy link

Codecov Report

Merging #1091 (c27f940) into main (44862bf) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   84.80%   84.68%   -0.13%     
==========================================
  Files          57       57              
  Lines        7801     7801              
  Branches     1259     1259              
==========================================
- Hits         6616     6606      -10     
- Misses        886      892       +6     
- Partials      299      303       +4     
Impacted Files Coverage Δ
src/snowflake/connector/ocsp_snowflake.py 71.08% <0.00%> (-0.89%) ⬇️
src/snowflake/connector/auth.py 79.10% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44862bf...c27f940. Read the comment docs.

@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/wheel_build branch 3 times, most recently from c7c7caf to 5fc62f3 Compare April 13, 2022 21:05
@sfc-gh-mkeller sfc-gh-mkeller changed the title switch to new build process SNOW-572600 switch to new build process Apr 13, 2022
@sfc-gh-mkeller sfc-gh-mkeller marked this pull request as ready for review April 13, 2022 21:30
Co-authored-by: Tanveen Bharaj <[email protected]>
@sfc-gh-mkeller sfc-gh-mkeller merged commit 7bb60da into main Apr 15, 2022
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/wheel_build branch April 15, 2022 20:49
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants