Skip to content

Commit

Permalink
fixing platformdirs incompatibility (#1609)
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-mkeller authored Jun 20, 2023
1 parent 695fcb6 commit 51749d2
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions DESCRIPTION.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Source code is also available at: https://github.com/snowflakedb/snowflake-conne
- Bumped cryptography dependency from <41.0.0,>=3.1.0 to >=3.1.0,<42.0.0.
- Improved OCSP response caching to remove tmp cache files on Windows.
- Added a parameter `server_session_keep_alive` in `SnowflakeConnection` that skips session deletion when client connection closes.
- Tightened our pinning of platformdirs, to prevent their new releases breaking us.

- v3.0.4(May 23,2023)
- Fixed a bug in which `cursor.execute()` could modify the argument statement_params dictionary object when executing a multistatement query.
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ install_requires =
typing_extensions>=4.3,<5
filelock>=3.5,<4
sortedcontainers>=2.4.0
platformdirs>=2.6.0,<4.0.0
platformdirs>=2.6.0,<3.7.0
tomlkit
include_package_data = True
package_dir =
Expand Down
5 changes: 5 additions & 0 deletions src/snowflake/connector/sf_dirs.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,8 @@ def user_pictures_dir(self) -> str:
def user_videos_dir(self) -> str:
"""videos directory tied to the user"""
return self.user_data_dir

@property
def user_downloads_dir(self) -> str:
"""downloads directory tied to the user"""
return self.user_data_dir

0 comments on commit 51749d2

Please sign in to comment.