Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added point about types to PR checklist #920

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki commented Sep 27, 2024

Description

Added to PR checklist point: "Extend the types in index.d.ts file (if necessary)

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner September 27, 2024 09:07
@sfc-gh-pmotacki sfc-gh-pmotacki changed the title Added to PR checklist point: "Extend the types in index.d.ts file (if… Added point about types to PR checklist Sep 27, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (599e55c) to head (00dd95f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
- Coverage   88.98%   88.93%   -0.05%     
==========================================
  Files          69       69              
  Lines        6754     6754              
==========================================
- Hits         6010     6007       -3     
- Misses        744      747       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the extend_pr_checklist_typings_verification branch from 9b4df7b to 1b7d572 Compare October 1, 2024 09:28
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the extend_pr_checklist_typings_verification branch 2 times, most recently from 57fa81a to 8a5a5ca Compare November 4, 2024 14:41
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the extend_pr_checklist_typings_verification branch from 8a5a5ca to 673e43c Compare November 14, 2024 09:30
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the extend_pr_checklist_typings_verification branch from 673e43c to 00dd95f Compare December 3, 2024 16:30
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit e6f30aa into master Dec 4, 2024
57 of 59 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the extend_pr_checklist_typings_verification branch December 4, 2024 07:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants