Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storagetest #706

Closed
wants to merge 46 commits into from
Closed

Storagetest #706

wants to merge 46 commits into from

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (46c2fa8) 87.39% compared to head (3eb3c49) 87.14%.

Files Patch % Lines
lib/services/sf.js 53.33% 7 Missing ⚠️
lib/authentication/auth_idtoken.js 71.42% 4 Missing ⚠️
lib/authentication/authentication.js 20.00% 4 Missing ⚠️
lib/authentication/secureStorage.js 88.88% 4 Missing ⚠️
lib/connection/connection.js 25.00% 3 Missing ⚠️
lib/authentication/auth_default.js 50.00% 1 Missing ⚠️
lib/authentication/auth_keypair.js 50.00% 1 Missing ⚠️
lib/authentication/auth_oauth.js 50.00% 1 Missing ⚠️
lib/authentication/auth_okta.js 50.00% 1 Missing ⚠️
lib/authentication/auth_web.js 66.66% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
- Coverage   87.39%   87.14%   -0.25%     
==========================================
  Files          61       63       +2     
  Lines        5791     5882      +91     
==========================================
+ Hits         5061     5126      +65     
- Misses        730      756      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the storagetest branch December 17, 2024 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant