SNOW-926008 supportability/observability enhancement for generic and proxy use-cases #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proxy use-cases - generic observability: instead of swallowing the underlying error upon connectivity issue and emit a hard-to-debug generic error message, log that underlying error stack on DEBUG loglevel - proxy: detecting if HTTP_PROXY/HTTPS_PROXY environmental variable is set, log them on DEBUG loglevel - proxy: added logging for Connection's proxyPort and proxyUser (if set), had only proxyHost. -- this bit of logging now moved to generic agent - proxy: if both HTTPS_PROXY and proxyHost is set, can lead to not-so-trivial-to-debug situations ; log this on WARN loglevel for more intuitive troubleshooting
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #699 +/- ##
==========================================
- Coverage 87.51% 87.40% -0.11%
==========================================
Files 61 61
Lines 5759 5789 +30
==========================================
+ Hits 5040 5060 +20
- Misses 719 729 +10 ☔ View full report in Codecov by Sentry. |
…e the env PROXY with the agent proxy settings and generate log messages accordingly * moved the proxy (env+agent) detection functionality into agent creation step to try and check it only once, upon agent creation time * adjusted unit tests accordingly
sfc-gh-dprzybysz
approved these changes
Nov 16, 2023
sfc-gh-dszmolka
deleted the
SNOW-926008-observability-for-proxy-usecases
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generic observability: instead of swallowing the underlying error upon connectivity issue and emit a hard-to-debug generic error message, log that underlying error stack on DEBUG loglevel
proxy: detecting if HTTP_PROXY/HTTPS_PROXY environmental variable is set, log them on DEBUG loglevel
proxy: added logging for Connection's proxyPort and proxyUser (if set), had only proxyHost.
-- this bit of logging now moved to generic agent
proxy: if both HTTPS_PROXY and proxyHost is set, can lead to not-so-trivial-to-debug situations ; log this on WARN loglevel for more intuitive troubleshooting