Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-859635: Retry Strategy v2 #687

Merged
merged 11 commits into from
Nov 6, 2023
Merged

SNOW-859635: Retry Strategy v2 #687

merged 11 commits into from
Nov 6, 2023

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Nov 2, 2023

Description

  • Edited default values of the retry options.
  • Replaced the option name 'loginTimeout' with 'retryTimeout'

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #687 (29bd355) into master (d7c33ea) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   87.65%   87.82%   +0.17%     
==========================================
  Files          61       61              
  Lines        5725     5725              
==========================================
+ Hits         5018     5028      +10     
+ Misses        707      697      -10     
Files Coverage Δ
lib/connection/connection_config.js 96.89% <100.00%> (+0.62%) ⬆️
lib/constants/error_messages.js 100.00% <100.00%> (ø)
lib/errors.js 96.63% <100.00%> (ø)
lib/services/sf.js 86.49% <100.00%> (ø)
lib/util.js 97.61% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

lib/util.js Outdated Show resolved Hide resolved
lib/util.js Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a user November 3, 2023 16:16
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please ask Snowflake for review.

Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat code in some places.
Rest LGTM

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review November 3, 2023 21:28
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner November 3, 2023 21:28
@sfc-gh-pmotacki
Copy link
Collaborator

LGTM

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit 97081e3 into master Nov 6, 2023
43 of 44 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the retrystrategyv2 branch November 6, 2023 23:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants