Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted retryStrategy for investigating #684

Closed
wants to merge 10 commits into from

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review October 31, 2023 17:58
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner October 31, 2023 17:58
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #684 (885075c) into master (8bfb622) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
+ Coverage   87.57%   87.59%   +0.01%     
==========================================
  Files          60       60              
  Lines        5628     5628              
==========================================
+ Hits         4929     4930       +1     
+ Misses        699      698       -1     
Files Coverage Δ
lib/connection/connection_config.js 96.27% <ø> (ø)
lib/services/sf.js 86.49% <ø> (ø)
lib/util.js 97.61% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-ext-simba-jy
Copy link
Collaborator Author

closed this PR because the same feature was merged on a different PR.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the retrystrategyissue branch December 17, 2024 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant