Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-334890 - fix tests running #665

Merged
merged 1 commit into from
Oct 11, 2023
Merged

SNOW-334890 - fix tests running #665

merged 1 commit into from
Oct 11, 2023

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pmotacki sfc-gh-pmotacki marked this pull request as ready for review October 11, 2023 09:49
@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner October 11, 2023 09:49
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit de3131d into master Oct 11, 2023
5 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-334890_fix_test_running branch October 11, 2023 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dheyman sfc-gh-dheyman sfc-gh-dheyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-pmotacki @sfc-gh-dheyman