Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-944710: Add account validation #692

Merged
merged 8 commits into from
Nov 13, 2023
Merged

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

Add account validation.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner November 8, 2023 14:55
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #692 (835db86) into master (2abf45c) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   87.52%   87.34%   -0.19%     
==========================================
  Files          61       61              
  Lines        5748     5759      +11     
==========================================
- Hits         5031     5030       -1     
- Misses        717      729      +12     
Files Coverage Δ
lib/connection/connection_config.js 96.62% <100.00%> (+0.04%) ⬆️
lib/constants/error_messages.js 100.00% <100.00%> (ø)
lib/errors.js 96.66% <100.00%> (+0.03%) ⬆️
lib/util.js 97.85% <100.00%> (+0.77%) ⬆️

... and 6 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 51b7994 into master Nov 13, 2023
43 of 44 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the validate-account branch November 13, 2023 09:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants