SNOW-856233 disable easy logging (#695)

SNOW-856233 disable easy logging
snowflakedb · Nov 9, 2023 · 2abf45c · 2abf45c
1 parent a073e14
commit 2abf45c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 21 deletions.
diff --git a/lib/connection/connection.js b/lib/connection/connection.js
@@ -15,10 +15,8 @@ var Statement = require('./statement');
 var Parameters = require('../parameters');
 var Authenticator = require('../authentication/authentication');
 var Logger = require('../logger');
-const {init: initEasyLogging} = require('../logger/easy_logging_starter')
 const {isOktaAuth} = require('../authentication/authentication');
 
-
 const PRIVATELINK_URL_SUFFIX = ".privatelink.snowflakecomputing.com";
 
 /**
@@ -273,19 +271,10 @@ function Connection(context)
       throw authErr;
     }
 
-    initEasyLogging(connectionConfig.clientConfigFile)
-      .then(() => {
-        try {
-          services.sf.connect({
-            callback: connectCallback(self, callback),
-            json: body
-          });
-        } catch (e) {
-          // we don't expect an error here since callback method should be called
-          Logger.getInstance().error('Unexpected error from calling callback function', e);
-        }
-      })
-      .catch(()  => callback(Errors.createClientError(ErrorCodes.ERR_CONN_CONNECT_INVALID_CLIENT_CONFIG)));
+    services.sf.connect({
+      callback: connectCallback(self, callback),
+      json: body
+    });
     return this;
   };
 
@@ -319,11 +308,6 @@ function Connection(context)
 
     try
     {
-      try {
-        await initEasyLogging(connectionConfig.clientConfigFile);
-      } catch (err) {
-        throw Errors.createClientError(ErrorCodes.ERR_CONN_CONNECT_INVALID_CLIENT_CONFIG);
-      }
       await auth.authenticate(connectionConfig.getAuthenticator(),
         connectionConfig.getServiceName(),
         connectionConfig.account,

diff --git a/lib/logger/easy_logging_starter.js b/lib/logger/easy_logging_starter.js
@@ -14,6 +14,7 @@ const getClientConfig = clientConfiguration.getClientConfig;
 let initTrialParameters;
 
 /**
+ * This is an experimental feature. Not ready to use yet.
  * @param {string} configFilePathFromConnectionString
  * @returns {Promise<void>}
  */
@@ -47,6 +48,9 @@ exports.init = async function (configFilePathFromConnectionString) {
   }
 };
 
+/**
+ * This is an experimental feature. Not ready to use yet.
+ */
 exports.reset = function () {
   initTrialParameters = undefined;
   Logger.getInstance().easyLoggingConfigureCounter = undefined;

diff --git a/test/integration/testEasyLoggingOnConnecting.js b/test/integration/testEasyLoggingOnConnecting.js
@@ -14,7 +14,7 @@ const {codes} = require('./../../lib/errors');
 const errorMessages = require('./../../lib/constants/error_messages');
 let tempDir = null;
 
-describe('Easy logging tests', function () {
+describe.skip('Easy logging tests', function () {
 
   before(async function () {
     tempDir = await fsPromises.mkdtemp(path.join(os.tmpdir(), 'easy_logging_connect_tests_'));