-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-859635: Retry Strategy v2 #687
Conversation
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
==========================================
+ Coverage 87.65% 87.82% +0.17%
==========================================
Files 61 61
Lines 5725 5725
==========================================
+ Hits 5018 5028 +10
+ Misses 707 697 -10
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please ask Snowflake for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reformat code in some places.
Rest LGTM
LGTM |
Description
Checklist
npm run lint:check -- CHANGED_FILES
and fix problems in changed code)npm run test:unit
andnpm run test:integration
)