Prevent memory leaks due to expired certs #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimbaGithub please check here: dotnet/runtime#52577 I still think we should merge this. |
|
@SimbaGithub @sfc-gh-hyu this also caused a sev1 for us. Can we please get this merged? |
This reverts commit 2850f33.
|
revert was only to keep diffs clean between this and #317... mixed a few things up with my internal private fork. |
|
cc @sfc-gh-hchaturvedi It seems that revocation list check leaks certs. Can you comment on this? |
|
Not sure what you mean by "leaks certs". It's a memory leak, and it's in .NET itself. Check dotnet/runtime#52577 |
|
Ah I see, sorry I misread. Reading the original thread now :) |
|
@sfc-gh-hyu for further context, please read newrelic/newrelic-dotnet-agent#544 |
|
seems like this was resolved in #328, closing to clean up the dead PR for the repo maintainers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/dotnet/core/issues/6229 and newrelic/newrelic-dotnet-agent#544
@SimbaGithub This should probably be released ASAP, it has a pretty devastating impact and is really hard to debug.