Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-761744 Added URL Validator and URL Encoder #757

Merged
merged 6 commits into from
Mar 21, 2023

Conversation

sfc-gh-hchaturvedi
Copy link
Collaborator

Description

Added URL Validator to ensure that the SSO URL being used in external browser is valid. Also added URL Encoder to encode base64 strings to url safe format.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@github-actions
Copy link

github-actions bot commented Mar 17, 2023

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@sfc-gh-hchaturvedi
@harsh Chaturvedi
Harsh Chaturvedi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@sfc-gh-hchaturvedi
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-hchaturvedi sfc-gh-hchaturvedi marked this pull request as ready for review March 20, 2023 21:04
@sfc-gh-hchaturvedi sfc-gh-hchaturvedi requested a review from a team as a code owner March 20, 2023 21:04
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-wshangguan
Copy link

So we just add some util functions without using them at this moment?

@sfc-gh-hchaturvedi sfc-gh-hchaturvedi merged commit e11a2a5 into master Mar 21, 2023
@sfc-gh-hchaturvedi sfc-gh-hchaturvedi deleted the hchaturvedi_snow_761744_add_urlvalidator branch March 21, 2023 00:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants