SNOW-1760222 Add test for raising PUT errors #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pbulawa
approved these changes
Oct 24, 2024
sfc-gh-pfus
force-pushed
the
SNOW-1760222-fail-query-when-file-no-uploaded
branch
from
f4b774b
to
fa64837
Compare
sfc-gh-pfus
force-pushed
the
SNOW-1760222-fail-query-when-file-no-uploaded
branch
from
fa64837
to
9dc05d7
Compare
sfc-gh-dheyman-1
approved these changes
Oct 25, 2024
|
LGTM. Are you planning to fix this in this PR? If not then change the title. |
sfc-gh-pfus
changed the title
Fixed PR title to adjust to commit msg. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1230 +/- ##
==========================================
+ Coverage 82.56% 82.57% +0.01%
==========================================
Files 55 55
Lines 13315 13315
==========================================
+ Hits 10993 10995 +2
+ Misses 2322 2320 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-1760222 Fixed swallowing errors during file upload to cloud storage
Checklist