SNOW-499317 Fix panic when disable telemetry enabled (#490)

snowflakedb · Nov 8, 2021 · 8ca3bb1 · 8ca3bb1
1 parent d2c78da
commit 8ca3bb1
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/connection.go b/connection.go
@@ -661,7 +661,7 @@ func buildSnowflakeConn(ctx context.Context, config Config) (*snowflakeConn, err
 		tokenAccessor = getSimpleTokenAccessor()
 	}
 	if sc.cfg.DisableTelemetry {
-		sc.telemetry.enabled = false
+		sc.telemetry = &snowflakeTelemetry{enabled: false}
 	}
 
 	// authenticate

diff --git a/telemetry_test.go b/telemetry_test.go
@@ -86,3 +86,18 @@ func TestTelemetrySQLException(t *testing.T) {
 		t.Errorf("there should be no telemetry data in log. found: %v", len(st.logs))
 	}
 }
+
+func TestDisableTelemetry(t *testing.T) {
+	config, _ := ParseDSN(dsn)
+	config.DisableTelemetry = true
+	sc, err := buildSnowflakeConn(context.Background(), *config)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if err = authenticateWithConfig(sc); err != nil {
+		t.Fatal(err)
+	}
+	if _, err = sc.Query("select 1", nil); err != nil {
+		t.Fatal(err)
+	}
+}