Add a flake for nixos-appstream-data #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing nixos-appstream-data as a flake will allow nix-software-center to depend on it the flake way, instead of via an IFD. Having nix-software-center use an IFD is problematic because users of that package may run into NixOS/nix#4265 Adding this flake does not cause an API change for non-flake users.
korfuri
added a commit
to korfuri/nix-software-center
that referenced
this pull request
Apr 11, 2024
I recently added a flake for nixos-appstream-data. This allows us to depend on that flake instead of doing an IFD to load its default.nix. An IFD in nix-software-center is problematic for users who use flakes and have multiple nixos configurations with different architectures. Because of NixOS/nix#4265 this causes `nix flake check` to fail for them. Note that users of nix-software-center that do not rely on the flake will still need an IFD. I'm not aware of a better way (other than upstreaming both in nixpkgs). TODO: point this back to snowfallorg's repo after snowfallorg/nixos-appstream-data#1 is merged.
korfuri
added a commit
to korfuri/nix-software-center
that referenced
this pull request
Apr 15, 2024
I recently added a flake for nixos-appstream-data. This allows us to depend on that flake instead of doing an IFD to load its default.nix. An IFD in nix-software-center is problematic for users who use flakes and have multiple nixos configurations with different architectures. Because of NixOS/nix#4265 this causes `nix flake check` to fail for them. Note that users of nix-software-center that do not rely on the flake will still need an IFD. I'm not aware of a better way (other than upstreaming both in nixpkgs). Ref: snowfallorg/nixos-appstream-data#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing nixos-appstream-data as a flake will allow nix-software-center to depend on it the flake way, instead of via an IFD. Having nix-software-center use an IFD is problematic because users of that package may run into NixOS/nix#4265
Adding this flake does not cause an API change for non-flake users.