Tags: snowdensb/caseflow
Tags
Update edit NOD permissions to just CoB (#16090) Resolves part of [CASEFLOW-1313](https://vajira.max.gov/browse/CASEFLOW-1313) ### Description Updates permissions for editing NOD date from attorneys, judges, intake users, and Clerk of the Board to just Clerk of the Board. ### Acceptance Criteria - [x] Code compiles correctly ### Testing Plan 1. Log in as `COB_USER` 2. Ensure you can edit an AMA appeal (210315-47 for example) 3. Switch to a judge, attorney, and intake user and ensure you can see the change in timeline on the appeal that was edited, but cannot edit NOD date
CASEFLOW-1052 Edit Cavc Remand (#16035) * Initial commit, link exists, permissions established * Remove comment, update link, need to update link to edit route once exists * created EditCavcRemandForm component; created stories for EditCavcRemandForm; added collection of alerts used in EditCavcRemandForm; additions to COPY to account for editing vs adding CAVC remands; * Bump Yup to 0.32.9 * additions to schema for EditCavcRemandForm * Updates to EditCavcRemandForm component & stories; * added jsDoc comments to EditCavcRemandForm * initial work on EditCavcRemandView * updates to EditCavicRemandForm; added jest tests for EditCavicRemandForm; * added CavcRemandSerializer; * updated frontend routing for edit_cavc_remand; updated EditCavcRemandView to pass along the correct info; * updated cavc_remand factory; updated CavcRemandSerializer; * updated CavcRemandsController & CavcRemand model to enable full editing functionality (note that additional logic is necessary to preserve existing functionality for updating MDR remands via existing modal) * added copy for CAVC remand edit success alert; fixes for conditional display logic in EditCavcRemandForm; EditCavcRemandView now handles both cancel and submission; * initial work on feature test for editing of CAVC remands * Fix merge issue * Fix model and controller for 90-day-letter-entry-method * More updates * Whitespace fix * Update to include source to modal test * Update snapshot * Sync branch * Added some of JCs logic back in * update TimedHoldTask for Mdr * capitalize decisionType and uppercase remandType * handle mandate dates provided * update MdrTask spec * fix json exporter spec and MandateHoldTask spec * fix mandate_hold_task_spec * show issues; otherwise none submitted * fix cavc_remand_spec * refactor to reduce if-then-else * fix cavc_remands_controller_spec * lint * more lint * create CavcTimedHoldConcern * clean up * delete extra end * have factorybot produce distinctive descriptions * workaround to display decisionType and remandType as nice words * minimize workaround * bugfix: use correct source_appeal_id * remove mandate dates if blank submitted * prevent issue changes for death dismissal * don't allow future mandate dates * add TODO to remove mandateSame * lint * appease CodeClimate * exclude util.js from code duplication check * retry excluding identical-code check * retry again, so close * remove parentheses from success message * refactor for CodeClimate * Fix toUpper not being liked in circleci * fix lint * Comment out section that fails that we didn't change * Update feature on failure that was not from our code; fix later * restore commented out code * committing again * fix test to use a decision date within the last 90 days * Remove jest tests for now * skip test coverage check for now * try again Co-authored-by: J.C. Quirin <2581274+jcq@users.noreply.github.com> Co-authored-by: yoomlam <Dung.Lam1@va.gov>
CASEFLOW-1052 Edit Cavc Remand (#16035) * Initial commit, link exists, permissions established * Remove comment, update link, need to update link to edit route once exists * created EditCavcRemandForm component; created stories for EditCavcRemandForm; added collection of alerts used in EditCavcRemandForm; additions to COPY to account for editing vs adding CAVC remands; * Bump Yup to 0.32.9 * additions to schema for EditCavcRemandForm * Updates to EditCavcRemandForm component & stories; * added jsDoc comments to EditCavcRemandForm * initial work on EditCavcRemandView * updates to EditCavicRemandForm; added jest tests for EditCavicRemandForm; * added CavcRemandSerializer; * updated frontend routing for edit_cavc_remand; updated EditCavcRemandView to pass along the correct info; * updated cavc_remand factory; updated CavcRemandSerializer; * updated CavcRemandsController & CavcRemand model to enable full editing functionality (note that additional logic is necessary to preserve existing functionality for updating MDR remands via existing modal) * added copy for CAVC remand edit success alert; fixes for conditional display logic in EditCavcRemandForm; EditCavcRemandView now handles both cancel and submission; * initial work on feature test for editing of CAVC remands * Fix merge issue * Fix model and controller for 90-day-letter-entry-method * More updates * Whitespace fix * Update to include source to modal test * Update snapshot * Sync branch * Added some of JCs logic back in * update TimedHoldTask for Mdr * capitalize decisionType and uppercase remandType * handle mandate dates provided * update MdrTask spec * fix json exporter spec and MandateHoldTask spec * fix mandate_hold_task_spec * show issues; otherwise none submitted * fix cavc_remand_spec * refactor to reduce if-then-else * fix cavc_remands_controller_spec * lint * more lint * create CavcTimedHoldConcern * clean up * delete extra end * have factorybot produce distinctive descriptions * workaround to display decisionType and remandType as nice words * minimize workaround * bugfix: use correct source_appeal_id * remove mandate dates if blank submitted * prevent issue changes for death dismissal * don't allow future mandate dates * add TODO to remove mandateSame * lint * appease CodeClimate * exclude util.js from code duplication check * retry excluding identical-code check * retry again, so close * remove parentheses from success message * refactor for CodeClimate * Fix toUpper not being liked in circleci * fix lint * Comment out section that fails that we didn't change * Update feature on failure that was not from our code; fix later * restore commented out code * committing again * fix test to use a decision date within the last 90 days * Remove jest tests for now * skip test coverage check for now * try again Co-authored-by: J.C. Quirin <2581274+jcq@users.noreply.github.com> Co-authored-by: yoomlam <Dung.Lam1@va.gov>
Add hearing to original_request_type/changed_request_type database fi… …elds and accompanying code (#16049) Resolves #15880 ### Description Renamed `original_request_type` to `original_hearing_request_type` and `changed_request_type` to `changed_hearing_request_type` in the database and throughout the codebase. ### Acceptance Criteria - [ ] Code compiles correctly ### Database Changes * [ ] Column comments updated * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Query profiling performed (eyeball Rails log, check bullet and fasterer output) * [ ] Appropriate indexes added (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] DB schema docs updated with `make docs` (after running `make migrate`) * [ ] #appeals-schema notified with summary and link to this PR
Docket Switch Bugs (#16088) * docket switch bugs * failing tests * updated tests
Remove confusing copy on case details page (#15967) Resolves #15578 ### Description Removes "Soon, you'll be able to see many more details" from the Case Timeline ### Acceptance Criteria - [x] Code compiles correctly ### User Facing Changes - [x] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER <img width="1425" alt="image" src="https://user-images.githubusercontent.com/2308626/110140713-5f2eab00-7da2-11eb-84f0-2e9c91696e27.png"> |<img width="1469" alt="image" src="https://user-images.githubusercontent.com/2308626/110140632-49b98100-7da2-11eb-996c-f7841820bfc5.png">
Submission for unrecognized appellant appeals (with POA) (#15940) * wip * tests passing * Frontend working * Appellant shows on case detail page * backend saving * fixing failing tests * tests passing * test passing * removed file * refactoring addIssues * poa showing on review page * wip * review working * tests passing * titleize * tests passing * tests passing * fixed lint errors * added attorney_power_of_attorney * tests passing * show poa when non_veteran_claimants feature toggle is enabled * WIP review changes * Fixes * Front-end and backend fixes, working on Jest tests * Test fixes * Remove unneeded export and line in spec * Various fixes * Test and formatting fixes * Code climate, fix veteran claimant fakes * Fix BGS fakes after code climate fix * Fix other claimant params * Fix veteran claimant birthdate in fakes * Test data fixes * Link person date of birth to test data Co-authored-by: Sally Maki <Sally.Maki@va.gov> Co-authored-by: va-bot <james.kassemi+vabot@adhocteam.us>
Bump yargs-parser from 5.0.0 to 5.0.1 in /client (#16026) Bumps [yargs-parser](https://github.com/yargs/yargs-parser) from 5.0.0 to 5.0.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/yargs/yargs-parser/releases">yargs-parser's releases</a>.</em></p> <blockquote> <h2>yargs-parser v5.0.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>security:</strong> address GHSA-p9pc-299p-vxgp (<a href="https://www.github-redirect.dependabot.com/yargs/yargs-parser/issues/362">#362</a>) (<a href="https://www.github.com/yargs/yargs-parser/commit/1c417bd0b42b09c475ee881e36d292af4fa2cc36">1c417bd</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/yargs/yargs-parser/blob/v5.0.1/CHANGELOG.md">yargs-parser's changelog</a>.</em></p> <blockquote> <h1><a href="https://github.com/yargs/yargs-parser/compare/v4.2.1...v5.0.0">5.0.0</a> (2017-02-18)</h1> <h3>Bug Fixes</h3> <ul> <li>environment variables should take precedence over config file (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/81">#81</a>) (<a href="https://github.com/yargs/yargs-parser/commit/76cee1f">76cee1f</a>)</li> </ul> <h3>BREAKING CHANGES</h3> <ul> <li>environment variables will now override config files (args, env, config-file, config-object)</li> </ul> <p><!-- raw HTML omitted --><!-- raw HTML omitted --></p> <h3><a href="https://www.github.com/yargs/yargs-parser/compare/v5.0.0...v5.0.1">5.0.1</a> (2021-03-10)</h3> <h3>Bug Fixes</h3> <ul> <li><strong>security:</strong> address GHSA-p9pc-299p-vxgp (<a href="https://www.github-redirect.dependabot.com/yargs/yargs-parser/issues/362">#362</a>) (<a href="https://www.github.com/yargs/yargs-parser/commit/1c417bd0b42b09c475ee881e36d292af4fa2cc36">1c417bd</a>)</li> </ul> <h2><a href="https://github.com/yargs/yargs-parser/compare/v4.2.0...v4.2.1">4.2.1</a> (2017-01-02)</h2> <h3>Bug Fixes</h3> <ul> <li>flatten/duplicate regression (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/75">#75</a>) (<a href="https://github.com/yargs/yargs-parser/commit/68d68a0">68d68a0</a>)</li> </ul> <p><!-- raw HTML omitted --><!-- raw HTML omitted --></p> <h1><a href="https://github.com/yargs/yargs-parser/compare/v4.1.0...v4.2.0">4.2.0</a> (2016-12-01)</h1> <h3>Bug Fixes</h3> <ul> <li>inner objects in configs had their keys appended to top-level key when dot-notation was disabled (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/72">#72</a>) (<a href="https://github.com/yargs/yargs-parser/commit/0b1b5f9">0b1b5f9</a>)</li> </ul> <h3>Features</h3> <ul> <li>allow multiple arrays to be provided, rather than always combining (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/71">#71</a>) (<a href="https://github.com/yargs/yargs-parser/commit/0f0fb2d">0f0fb2d</a>)</li> </ul> <p><!-- raw HTML omitted --><!-- raw HTML omitted --></p> <h1><a href="https://github.com/yargs/yargs-parser/compare/v4.0.2...v4.1.0">4.1.0</a> (2016-11-07)</h1> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/yargs/yargs-parser/commit/eab6c039888bd5d51f33dda7a98808564acfa938"><code>eab6c03</code></a> chore: release 5.0.1 (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/363">#363</a>)</li> <li><a href="https://github.com/yargs/yargs-parser/commit/1c417bd0b42b09c475ee881e36d292af4fa2cc36"><code>1c417bd</code></a> fix(security): address GHSA-p9pc-299p-vxgp (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/362">#362</a>)</li> <li><a href="https://github.com/yargs/yargs-parser/commit/e93a345e1e585ba5df97c1da438673e7f2e8909b"><code>e93a345</code></a> chore: mark release in commit history (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/361">#361</a>)</li> <li><a href="https://github.com/yargs/yargs-parser/commit/ee15863f7c62418c4fc92b64c3488778c46833dc"><code>ee15863</code></a> chore: push new package version</li> <li><a href="https://github.com/yargs/yargs-parser/commit/47742078426f0e4e02aa988062b5fb0fa61182b9"><code>4774207</code></a> fix: back-porting prototype fixes for <em>really</em> old version (<a href="https://github-redirect.dependabot.com/yargs/yargs-parser/issues/271">#271</a>)</li> <li>See full diff in <a href="https://github.com/yargs/yargs-parser/compare/v5.0.0...v5.0.1">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~oss-bot">oss-bot</a>, a new releaser for yargs-parser since your current version.</p> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=yargs-parser&package-manager=npm_and_yarn&previous-version=5.0.0&new-version=5.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/department-of-veterans-affairs/caseflow/network/alerts). </details>
Use loading button state after confirming docket switch (#16067) Connects [CASEFLOW-1247](https://vajira.max.gov/browse/CASEFLOW-1247) and companion PR to #16055 ### Description This PR builds upon #16055 by adding a loading state to the Docket Switch confirmation page, and using that instead of disabled when awaiting confirmation, so that the user sees an animated loading button as they wait. ### Testing Plan 1. All tests still passing 2. To see a relevant feature test in action, put a `binding.pry` in `spec/feature/queue/docket_switch_spec.rb` around L348, which pauses the feature test right at the confirmation step. ### User Facing Changes Screenshot of the loading state (which does not capture the fun little animated Caseflow logo) -- <img width="506" src="https://user-images.githubusercontent.com/282869/112910974-73747800-90c2-11eb-8b69-2d6427b1e09c.png">
BUG: Receipt Date of Docket Switch on Docket Switch Confirmation Page… … Incorrect (#16063) Connects https://vajira.max.gov/browse/CASEFLOW-1261 ### Description When processing the docket switch as the COB user, the receipt date entered changed on the confirmation page for all of the docket switches I processed today. As indicated in the snips below, I entered the docket switch receipt date as “3/26/2021” on the first page; however, on the confirmation page, the date reverted to “3/25/2021,” which was the date of receipt of the VA Form 10182 for all of these appeals. ### Acceptance Criteria - [x] docketSwitchReceiptDate shows the receipt date entered changed on the confirmation page ### User Facing Changes <img width="1211" alt="Screen Shot 2021-03-29 at 2 34 47 PM" src="https://user-images.githubusercontent.com/23080951/112885539-e2d87080-909e-11eb-89c3-772a52e5a77e.png"> <img width="1317" alt="Screen Shot 2021-03-29 at 2 35 33 PM" src="https://user-images.githubusercontent.com/23080951/112885540-e2d87080-909e-11eb-9ca8-2682d025fa53.png">
PreviousNext