chore: Add example projects #91
Conversation
|
I like the examples like these in frameworks such as Django, FastAPI and bigger "frameworks", but I think it is a bit much to have 5 folders for a tiny package like this? 🤔 In other words, I don't really think it adds much more than the single demo project. Maybe it will make more sense when packages are split up and tests have to be rewritten in isolation, but right now I don't really see what it adds, except rewriting a bunch of tests? |
|
These wouldn't be used for tests at all. It's more a case of, if you need to know how to implement working celery integration filters, then you look at the celery example. If you need to ignore an URL, then look at the ignore URL example. The async-view example only contains the bare minimum configuration you need to set up the middleware. A full demo project is less useful IMO, because it includes a lot of bloat. If you want to just set up a basic configuration without integrations, then it's a shame if the logging configuration sets up the celery logging and vice versa. I think using the demo project for testing is something we should get rid of if that's still a thing 🙂 |
I don't think this makes as much sense for Django as it does for starlette-based projects tbh. |
I like the idea of small runnable examples. This sets up the starting point for that by adding
The goal here has been to remove anything that isn't relevant to the very narrow functionality the examples are meant to show. The sync-views example now has a regular view and an ignored view, and we might actually go one step further and make a dedicated example out of the ignored view.
If you agree, we can do something like:
For now, I just wanted to open this as a first WIP proof of concept
Update: Added examples for the 6 things I consider important. We might be missing something though 🙂