Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UUID_FORMAT config #81

Merged
merged 11 commits into from
May 6, 2022
Merged

Add UUID_FORMAT config #81

merged 11 commits into from
May 6, 2022

Conversation

Mdslino
Copy link
Contributor

@Mdslino Mdslino commented May 2, 2022

PR adds the option to formating the current generated GUID in the available formats.

@Mdslino
Copy link
Contributor Author

Mdslino commented May 2, 2022

Closes #80

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #81 (e103fb8) into main (93011f9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #81   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines          922       968   +46     
=========================================
+ Hits           922       968   +46     
Impacted Files Coverage Δ
django_guid/__init__.py 100.00% <100.00%> (ø)
django_guid/config.py 100.00% <100.00%> (ø)
django_guid/utils.py 100.00% <100.00%> (ø)
tests/conftest.py 100.00% <100.00%> (ø)
tests/functional/test_sync_middleware.py 100.00% <100.00%> (ø)
tests/unit/test_config.py 100.00% <100.00%> (ø)
tests/unit/test_uuid_length.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93011f9...e103fb8. Read the comment docs.

@JonasKs
Copy link
Member

JonasKs commented May 3, 2022

Seems like pre-commit needs an update. Please run pre-commit install, pre-commit autoupdate and pre-commit run —-all-files and commit changes. There’s is some MyPy errors that needs to be fixed too.

Ignore any integration flake8 errors.

docs/settings.rst Outdated Show resolved Hide resolved
docs/settings.rst Outdated Show resolved Hide resolved
@Mdslino Mdslino requested a review from sondrelg May 3, 2022 14:19
Copy link
Member

@sondrelg sondrelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty happy with these changes. @JonasKs want to take a look?

django_guid/config.py Outdated Show resolved Hide resolved
@JonasKs
Copy link
Member

JonasKs commented May 3, 2022

I will have a look tomorrow when I’m back home 😊

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Sondre Lillebø Gundersen <sondrelg@live.no>
@JonasKs
Copy link
Member

JonasKs commented May 4, 2022

I'd love a test that use it in a log message, but not critical if you don't have time to add it. I can do that later.

Looks good to me 😊 thank you so much!
(I'll merge when I'm on a computer, if you don't want to add the test)

@Mdslino
Copy link
Contributor Author

Mdslino commented May 5, 2022

@JonasKs I added some more tests. Please check if it is what you had in mind.

@JonasKs
Copy link
Member

JonasKs commented May 5, 2022

Perfect! 😊 Thank you so much!

I’ll merge if Sondre don’t beat me to it tomorrow!

@JonasKs JonasKs merged commit 6b535cb into snok:main May 6, 2022
@JonasKs
Copy link
Member

JonasKs commented May 6, 2022

Thank you so much! 😊 Should be released any minute on PyPI now.

https://github.com/snok/django-guid/releases/tag/3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants