-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UUID_FORMAT config #81
Conversation
Closes #80 |
Codecov Report
@@ Coverage Diff @@
## main #81 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 922 968 +46
=========================================
+ Hits 922 968 +46
Continue to review full report at Codecov.
|
Seems like pre-commit needs an update. Please run Ignore any integration flake8 errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty happy with these changes. @JonasKs want to take a look?
I will have a look tomorrow when I’m back home 😊 |
Co-authored-by: Sondre Lillebø Gundersen <sondrelg@live.no>
I'd love a test that use it in a log message, but not critical if you don't have time to add it. I can do that later. Looks good to me 😊 thank you so much! |
@JonasKs I added some more tests. Please check if it is what you had in mind. |
Perfect! 😊 Thank you so much! I’ll merge if Sondre don’t beat me to it tomorrow! |
Thank you so much! 😊 Should be released any minute on PyPI now. https://github.com/snok/django-guid/releases/tag/3.3.0 |
PR adds the option to formating the current generated GUID in the available formats.