Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Multiple idps #201

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP: Multiple idps #201

wants to merge 3 commits into from

Conversation

peterfarrell
Copy link
Contributor

WIP for #117

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #201 (c45c685) into master (e9808eb) will increase coverage by 0.2%.
The diff coverage is 79.5%.

@@           Coverage Diff            @@
##           master    #201     +/-   ##
========================================
+ Coverage    85.9%   86.1%   +0.2%     
========================================
  Files          11      11             
  Lines         497     505      +8     
========================================
+ Hits          427     435      +8     
  Misses         70      70             
Impacted Files Coverage Δ
django_auth_adfs/config.py 87.8% <79.5%> (+0.4%) ⬆️

@sondrelg
Copy link
Member

Hi @peterfarrell. What's the status for this PR? 🙂

@peterfarrell
Copy link
Contributor Author

@sondrelg Still a WIP and blocked by: jpadilla/pyjwt#433

@JonasKs
Copy link
Member

JonasKs commented Jan 3, 2022

Did you see my comment in #117 @peterfarrell ?

@peterfarrell
Copy link
Contributor Author

@JonasKs Yes, I did. I don't have the bandwidth to retro-fit anything more than a static list of issuers right now. I'm not familiar with Python-Jose. Does it have the same API as pyJWT?

@JonasKs
Copy link
Member

JonasKs commented Jan 4, 2022

Pretty much, yeah. It is a cleaner implementation, imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants