Better handling of internal failure modes and fix section bug #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 92.61% 93.29% +0.68%
==========================================
Files 2 2
Lines 1272 1237 -35
==========================================
- Hits 1178 1154 -24
+ Misses 94 83 -11
Continue to review full report in Codecov by Sentry.
|
tocic
reviewed
Apr 12, 2023
doc/coding_guidelines.md
Outdated
| - Functions in `<algorithm>` ([except `std::stable_sort`, `std::stable_partition`, and `std::inplace_merge`](https://stackoverflow.com/a/46714875/1565581)). | ||
| - Concepts and type traits. | ||
|
|
||
| Any type or function not listed above *should* be assumed to use heap memory unless demonstrated otherwise. One way to monitor this is on Linux is to use [valgrind/massif](https://valgrind.org/docs/manual/ms-manual.html). |
There was a problem hiding this comment.
-One way to monitor this is on Linux is to use
+One way to monitor this on Linux is to use
tocic
reviewed
Apr 12, 2023
doc/coding_guidelines.md
Outdated
|
|
||
| Therefore: | ||
| - Place as much code as possible in the `*.cpp` files rather than in headers. | ||
| - When not possible (templates, constexpr, etc.), consider if you can use a short and clear hand-written alternative instead. For example, `std::max(a, b)` requires `<algorithm>`, but can also be written as `a > b ? a : b`. Some of the simplest algorithms in `<algorithm>`, like `std::copy`, can also be written with an explicit loop. |
There was a problem hiding this comment.
-and clear hand-written alternative instead
+and clear handwritten alternative insteadThere was a problem hiding this comment.
The more you know :) Thanks
cschreib
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
snitch::small_functionto stronger invariants (always contains a function to call). This is technically a breaking change (the class lost itsempty()member, and is no longer default-constructible), but this should not affect anyone using snitch as a testing framework.std::terminateto a customizable assertion handler (terminates by default, but can be made to throw instead for testing).noexceptto the whole code. This led to a minor but measurable performance degradation (on compilation time mostly).