Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify is_match's early exit condition #65

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Simplify is_match's early exit condition #65

merged 1 commit into from
Feb 2, 2023

Conversation

tocic
Copy link
Member

@tocic tocic commented Feb 1, 2023

No description provided.

@cschreib cschreib merged commit 8dc9f62 into snitch-org:main Feb 2, 2023
@cschreib
Copy link
Member

cschreib commented Feb 2, 2023

Yep, that's correct. Thank you. I'm actually wondering if we should simply remove this if entirely, otherwise there is no way with is_match() to match only empty strings... Whether that's useful, I don't know 🤷 Let's see if it comes up later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants