-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for wildcards in CLI test and tag filters #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 92.75% 92.56% -0.20%
==========================================
Files 2 2
Lines 994 1049 +55
==========================================
+ Hits 922 971 +49
- Misses 72 78 +6
Continue to review full report at Codecov.
|
This reverts commit da62fd0.
I re-ran all benchmarks, since all runtime timings for snitch inexplicably went up significantly on my machine (even going back to previous commits with recorded runtime timings). It could be the BIOS update I did a week ago, or the kernel update. This time I used a script to run all benchmarks, which may reduce variability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
*
match-all character) in filters on the command line interface, for both tags and test case names.~...
).NAME [TYPE]
toNAME <TYPE>
to prevent ambiguity with tags.std::chrono::steady_clock
instead ofhigh_resolution_clock
, since the latter can end up being a typedef tosystem_clock
, which is less desirable.Note on benchmarks: For some reason I have not yet been able to identify, the runtime benchmarks on my machine have generally become slower in the past weeks. I had to re-run all the benchmarks for the competitor libraries, to compare on the same grounds. It seems that most of the run time in snitch is spent in
std::chrono::steady_clock::now()
, which is used to report test duration. SettingSNITCH_WITH_TIMINGS = 0
brings the snitch run time performance on par with Boost.UT. I don't know what could have changed in my machine to make time measurements much slower, but I did upgrade linux kernel and BIOS.