feature switch for thread_local variables and multi-threading #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 93.87% 93.87%
=======================================
Files 27 27
Lines 1664 1664
=======================================
Hits 1562 1562
Misses 102 102
Continue to review full report in Codecov by Sentry.
|
cschreib
reviewed
Apr 27, 2024
cschreib
reviewed
Apr 27, 2024
cschreib
reviewed
Apr 27, 2024
|
The CI failures weren't related to this PR and have been fixed in |
thread local variables will trigger a memory allocation on a bare metal system. use a macro to define the variable as thread local. Bare metal by definition has no threads and so needs no qualifier.
Cleanup of option documentation, usage, and meson configuration. Based on code review in merge request from cschreib.
CrustyAuklet
force-pushed
the
build-option-threading
branch
from
af299a1 to
73f4935
Compare
cschreib
approved these changes
Apr 27, 2024
tocic
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thread local variables will trigger a memory allocation on a bare metal system. When running tests on a single thread, or a system without threads, there is no benefit to using a
thread_localvariable. As discussed in #158.This change creates a feature flag to control if snitch should be compiled with support for threading. A macro
SNITCH_THREAD_LOCALis defined in the config header that resolves to nothing when the feature flag is disabled, orthread_localwhen it is enabled. The feature flag is enabled by default to preserve existing behavior.I names the feature flag
SNITCH_WITH_MULTITHREADINGto let it be used for any future threading features as well. If you want a more granular option that is an easy change.I updated the CMake project file, and the meson options. I don't use meson so someone double checking my work there would be great. The change seems simple enough though 😄