-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depreciation fix #27
Merged
Merged
Depreciation fix #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
ghost
mentioned this pull request
May 20, 2015
This was referenced Jun 9, 2015
Closed
This was referenced Jun 12, 2015
Closed
Closed
3 tasks
2 tasks
2 tasks
2 tasks
2 tasks
2 tasks
2 tasks
2 tasks
2 tasks
This was referenced Aug 22, 2023
Closed
2 tasks
2 tasks
ghost
mentioned this pull request
Jan 11, 2024
2 tasks
2 tasks
2 tasks
Closed
2 tasks
This was referenced Jun 20, 2024
2 tasks
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depreciation now does math based on Year and month - completely ignoring day.
It figures out the number of year-mo's since year 0 - the math looking like this:
year*12 + (month-1)
The month-1 thing is to make months be zero-based instead of one-based (January is 0, December is 11).
Formatting dates into that format and then subtracting gives you a 'rounded month difference' - e.g. February 1 minus january 31 is one month. February 28 minus february 1 is zero months.
I also put some error checking in around zero-length depreciation (causes a division-by-zero error otherwise), as well as non-existent deprecations themselves.
Fixes #1