-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set webhook content type (#15952) #15953
Set webhook content type (#15952) #15953
Conversation
💖 Thanks for this pull request! 💖 We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
We send json payload in HTTP `POST`. Communicate this explicitly towards the server by setting content-type header appropriately.
PR Summary
|
Content type for json is `application/json` without the plural `s`
7e9305c
to
a8f153b
Compare
On second thought one might want to get rid of the |
@sgross-emlix could you retarget this PR to develop? thanks |
I've fixed that typo on develop and master. Thanks for the heads up! |
Description
Set correct content type for webhook's json payload.
Fixes #15952
Type of change
How Has This Been Tested?
See related issue's reproduction steps
Result is now :
Your General Webhook Integration works!
And the gitlab pipeline is actually triggered
Checklist: