Bug with deleting assets

[snipe]

Start with the demo data in the database.

1. Delete the last computer asset (Noah MBP)
2. Create a new computer asset and check it out
3. Attempt to checkout a software license and assign to the new computer. Fails with "Error: admin/licenses/message.asset_does_not_exist"
4. Create another new computer asset and check it out
5. Check out a software license to the new computer. It appears to work but is actually assigned to the asset created in step 2.

[dookie2000ca]

These are the queries that happen prior to the error:

select * from users where users.deleted_at is null and id = '1' limit 1570μs
select * from throttle where user_id = '1' limit 1310μs
select groups.*, users_groups.user_id as pivot_user_id, users_groups.group_id as pivot_group_id from groups inner join users_groups on groups.id = users_groups.group_id where users_groups.user_id = '1'380μs
select * from assets where assets.deleted_at is null and id = '12' limit 1

The id should be 13, not 12. The DB output shows that 12 was deleted as it should be:

| 12 | Noah MBP | 2014-08-15 13:05:21 |
| 13 | dookbook-air | NULL |

[snipe]

Thank you for the additional info, @dookie2000ca!

[snipe]

"Error: admin/licenses/message.asset_does_not_exist" also shows me that we're missing a language string there. :(

[snipe]

Does the deleted asset show up in the dropdown for the license checkout?

[dookie2000ca]

No, it's gone from the dropdown and everywhere else.

[snipe]

Thank you - I think I see what's happening. I think the array index as the array is being built in the controller is being used as the id instead of the ID being used as the ID, which will cause hit or miss results when assigning. Very good catch, I'm sorry for the hassle. :( Working on a fix. (My local dev environment has been facacta recently, but will try to get it back up.)

[dookie2000ca]

Better to catch it now than later on down the road. I'll keep an eye out for the fix and test it out when it's ready.

[snipe]

It's exactly as I suspected.

[dookie2000ca]

Confirmed good fix. Thanks for the quick work on it!

[snipe]

My pleasure - thanks again for the heads up! I hope that didn't cause too many headaches for our users. :(