Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no information provided about the length constraint of password at installation time #139

Closed
rashivkp opened this issue May 6, 2014 · 1 comment

Comments

@rashivkp
Copy link

rashivkp commented May 6, 2014

after Installing a fresh snipe-it app with a less than 8 char password, the length validation of password won't allow you to login.

if we could inform the constraint at installation time, we can avoid the situation.

@snipe
Copy link
Owner

snipe commented May 6, 2014

The command line tool doesn't enforce password requirements:

protected function askUserPassword()
{
    do
    {
        // Ask the user to input the user password
        $password = $this->ask('Please enter your user password: ');

        // Check if email is valid
        if ($password == '')
        {
            // Return an error message
            $this->error('Password is invalid. Please try again.');
        }

        // Store the password
        $this->userData['password'] = $password;
    }
    while( ! $password);
}

That said, the login screen shouldn't be checking password length either, just the create/edit user section. I'll fix - thanks!

@snipe snipe closed this as completed in 3518ab9 May 6, 2014
snipe added a commit that referenced this issue May 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants