Skip to content

Commit

Permalink
Updates to K7 nav drawer and EUI to 9.4.0 (elastic#32864)
Browse files Browse the repository at this point in the history
* update for new eui nav drawer

* remove extraAction on flyout

* fix mobile menu toggle

* add i18n for recently reviewed nav link

* progress on updating tests

* replace EuiListGroup with EuiNavDrawerGroup

* Quick label fixes

- Removing aria-label if the same as label since the `EuiNavDrawerGroup` takes care of that
- Truncating any recent items to just 64 characters and applying the `title` attribute to display the whole label.

* Adding a truncation buffer

* fix navDrawerRef

* Update to EUI 9.3.0

Also comments out some logos that don’t exist that were throwing console errors

* remove unused import

* typo fix

* One DTS too many in test

* …all the small things…

* Upgrade plugin dependencies and fix nav drawer test

* update for new eui nav drawer

* remove extraAction on flyout

* fix mobile menu toggle

* add i18n for recently reviewed nav link

* progress on updating tests

* replace EuiListGroup with EuiNavDrawerGroup

* Quick label fixes

- Removing aria-label if the same as label since the `EuiNavDrawerGroup` takes care of that
- Truncating any recent items to just 64 characters and applying the `title` attribute to display the whole label.

* Adding a truncation buffer

* fix navDrawerRef

* Update to EUI 9.3.0

Also comments out some logos that don’t exist that were throwing console errors

* remove unused import

* typo fix

* One DTS too many in test

* …all the small things…

* Upgrade plugin dependencies and fix nav drawer test

* Add support for normal image paths

Updated to EUI 9.4.0

* update testing appMenu.clickLink selector

* leave appsMenu closed while reading and clicking links

* use saveVisualizationExpectSuccess to ensure modal is closed before continuing
  • Loading branch information
Ryan Keairns authored and snide committed Mar 14, 2019
1 parent 8202893 commit df37222
Show file tree
Hide file tree
Showing 12 changed files with 202 additions and 339 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ It allows you to monitor the performance of thousands of applications in real ti
'{config.docs.base_url}guide/en/apm/get-started/{config.docs.version}/index.html',
},
}),
euiIconType: 'apmApp',
euiIconType: 'logoAPM',
artifacts: artifacts,
onPrem: onPremInstructions(config),
elasticCloud: createElasticCloudInstructions(config),
Expand Down
67 changes: 67 additions & 0 deletions src/legacy/core_plugins/kibana/server/tutorials/nats_logs/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import { i18n } from '@kbn/i18n';
import { TUTORIAL_CATEGORY } from '../../../common/tutorials/tutorial_category';
import { onPremInstructions, cloudInstructions, onPremCloudInstructions } from '../../../common/tutorials/filebeat_instructions';

export function natsLogsSpecProvider(server, context) {
const moduleName = 'nats';
const geoipRequired = false;
const uaRequired = false;
const platforms = ['DEB', 'RPM'];
return {
id: 'natsLogs',
name: i18n.translate('kbn.server.tutorials.natsLogs.nameTitle', {
defaultMessage: 'Nats logs',
}),
category: TUTORIAL_CATEGORY.LOGGING,
isBeta: true,
shortDescription: i18n.translate('kbn.server.tutorials.natsLogs.shortDescription', {
defaultMessage: 'Collect and parse logs created by Nats.',
}),
longDescription: i18n.translate('kbn.server.tutorials.natsLogs.longDescription', {
defaultMessage: 'The `nats` Filebeat module parses logs created by Nats. \
[Learn more]({learnMoreLink}).',
values: {
learnMoreLink: '{config.docs.beats.filebeat}/filebeat-module-nats.html',
},
}),
// euiIconType: 'logoNats',
artifacts: {
dashboards: [
{
id: 'Filebeat-nats-overview-ecs',
linkLabel: i18n.translate('kbn.server.tutorials.natsLogs.artifacts.dashboards.linkLabel', {
defaultMessage: 'Nats logs dashboard',
}),
isOverview: true
}
],
exportedFields: {
documentationUrl: '{config.docs.beats.filebeat}/exported-fields-nats.html'
}
},
completionTimeMinutes: 10,
previewImagePath: '/plugins/kibana/home/tutorial_resources/nats_logs/screenshot.png',
onPrem: onPremInstructions(moduleName, platforms, geoipRequired, uaRequired, context),
elasticCloud: cloudInstructions(moduleName, platforms),
onPremElasticCloud: onPremCloudInstructions(moduleName, platforms)
};
}
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export function natsMetricsSpecProvider(server, context) {
learnMoreLink: '{config.docs.beats.metricbeat}/metricbeat-module-nats.html',
},
}),
euiIconType: 'logoNats',
// euiIconType: 'logoNats',
artifacts: {
dashboards: [
{
Expand Down
1 change: 1 addition & 0 deletions src/legacy/ui/public/chrome/api/nav.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export interface NavLink {
subUrlBase: string;
id: string;
euiIconType: IconType;
icon?: string;
active: boolean;
lastSubUrl?: string;
hidden?: boolean;
Expand Down
Loading

0 comments on commit df37222

Please sign in to comment.