Migrate intelv2 aa1 to implement 2 #132
Open
+6,201
−3,798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeet old out of existence, yeet new into existence.
The register component has been reworked.
The labels have been improved.
All actions have been removed. User actions like login, logout, and getPerson have been implemented.
LoginForm and HomePage have been adjusted to work with the new user actions and state definition.
Code was commented out to avoid errors caused by deleting the actions.
Now it is possible to fetch persons which get stored in the store as fetchedPerson.
The logout action has been imported from another location.
Cleanup and person action integration
Incorrect dispatches in the person action have been fixed.
Some non existent action has been removed.
The modal to connect other accounts has been added.
Some functions have been introduced.
Now it is possible again to search users.
A action for getting all gitlab servers for registration has been added.
Some more functionality has been added.
Types have been improved. Naming has been improved.
The get gitlab servers action is now exported correctly. Also undefined variables have been removed.
The reducers are now correctly added to the root reducer.
The registration has been unyeeted.
The registration action has been added. It calls the login action after.
Get persons brief and get person have been moved to the general actions. The person actions should only contain actions for the currently logged person.
Following actions and their reducers have been added: - All Achievements - Person Settings - Person Meta Link - Person Profiles - Person Add Profile - Person Delete Profile - Person Update Profile - Person Instagram Posts - Person Process Profiles - Person Follow - Person Unfollow - Person Like - Person Unlike
Following actions and their reducers have been added: - Enterprise General - Enterprise Projects - Enterprise Users
Following actions and their reducers have been added: - Redeem Achievement
A type has been fixed. Yey.
The export of register in the user action has been added.
Now it is possible to check if a specific username is already taken.
The photo map data and display was updated.
Now the map is only displayed if displayMap is enabled.
it is no checked if the user is logged in and if its his profile.
The modal should now only show up at the own page and now close without errors.
Now the talks page works again. It is also possible to leave a comment.
The action now returns an achievement.
The achievement tab was updated.
Now the select images button is only displayed if at least one instagram profile is connected.
Now intel and client no longer uses a local version of the snek engine but the production one on engine.snek.at.
Some dependencies have been updated due to security vulnerabilities and intel and client releases.
schettn
requested changes
Nov 10, 2020
src/Routes.js
Outdated
Comment on lines
36
to
40
| <Route | ||
| exact | ||
| path="/t/:username/:uid" | ||
| component={(props) => <TalkPage {...props} />} | ||
| path="/temp" | ||
| component={(props) => <TempPage {...props} />} | ||
| /> |
There was a problem hiding this comment.
All "Temp" component should be removed.
| calculateSources = (nextPropsYear) => { | ||
| const { statistic } = this.props; | ||
| calculateSources = (nextPropsYearIndex) => { | ||
| const { yearsStatistic, currentStatistic } = this.props; | ||
|
|
||
| let totalReviews = 0; | ||
| let totalIssues = 0; | ||
| let totalRequests = 0; | ||
| let totalCommits = 0; | ||
| let totalSources = 1; |
There was a problem hiding this comment.
@Aichnerc why is totalSources = 1. Shouldn't it be equals to 0?
Comment on lines
26
to
28
| state = { | ||
| loggedUser: null, | ||
| }; |
There was a problem hiding this comment.
I think it would be better not to store the whole loggedUser into the state.
We should load only required datasets into the state.
Comment on lines
51
to
62
| let loggedUser = this.props.loggedUser; | ||
| let follows = []; | ||
|
|
||
| for (let count in loggedUser.person.follows) { | ||
| follows.push(loggedUser.person.follows[count]); | ||
| } | ||
|
|
||
| follows.push({ slug: "p-" + personToFollow }); | ||
|
|
||
| loggedUser.person.follows = follows; | ||
|
|
||
| this.setState({ loggedUser }); |
There was a problem hiding this comment.
This should be reworked.
- Use the new state defined above.
- Then remove the for loop. This workaround is no longer required. (
loggedUser.followsis readOnly)
Comment on lines
74
to
80
| for (let count in loggedUser?.person?.follows) { | ||
| if (loggedUser.person.follows[count].slug !== "p-" + personToUnfollow) { | ||
| follows.push(loggedUser.person.follows[count]); | ||
| } | ||
| } | ||
|
|
||
| loggedUser.person.follows = follows; |
There was a problem hiding this comment.
This should be reworked:
- Use the new state defined above
- Rework the remove algorithm as follows:
var members = [
{name: 'Anna', class: 'one'},
{name: 'Bob', class: 'two'},
{name: 'Chuck', class: 'two'}];
var idx = members.findIndex(p => p.class=="two");
var removed = members.splice(idx,1);
console.log(removed);
console.log(members);
Comment on lines
89
to
95
| for (let count in loggedUser?.person?.follows) { | ||
| if (loggedUser.person.follows[count].slug === follower.slug) { | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| return false; |
Comment on lines
+25
to
+36
| class LikesModal extends React.Component { | ||
| state = { | ||
| loggedUser: null, | ||
| }; | ||
|
|
||
| componentDidMount = () => { | ||
| const { loggedUser } = this.props; | ||
|
|
||
| this.setState({ | ||
| loggedUser: loggedUser, | ||
| }); | ||
| }; |
Comment on lines
+67
to
+69
| for (let count in this.state.achievements) { | ||
| achievements.push(this.state.achievements[count]); | ||
| } |
The code quality was improved due to a request by Codacy.
The temp page which implemented all newer components is removed now because it is no longer required.
This code was never used therefore I removed it.
The new implementation is more suitable for larger ones records but does not fully work yet
The page refreshing has been improved.
Now every time handleModalClose is called, the infocard gets new data.
All uncommented console logs have been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior? (link to any open issues here)
What is the new behavior (if this is a feature change)?
Other information: