Migrate snekclientv2 aa1 to implement 1 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the search uses a new task which delivery only user pages. Therefore filtering is no longer needed. Previously there was a plain username string list which got replaced by a object list containing slugs and titles.
The argument has been updated to fit the new structure.
The login does no longer need a environment file including the anonymous username. The anonymous status can be be obtained directly from the authentication object.
The package has been downgraded to 11.0.7 due to issues with the latest version. Ref: mosch/react-avatar-editor#340
The package.json has been updated with the beta release of v2 SnekClient.
schettn
commented
Aug 5, 2020
kleberbaum
requested changes
Aug 5, 2020
Now when whoami is undefined the condition will not pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior? (link to any open issues here)
What is the new behavior (if this is a feature change)?
Other information: