Use site: search token for Reddit. #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution, this is great! The CI failure is unrelated, and should be fixed now, feel free to rebase and re-push. Also sadly we don't have unit test coverage for this specific code path, but we should, I'll plan to add that soon. Mind adding a link to the reddit API or search docs that describe these operators? Either to the |
The previous search would not find results submitted to the site if the post title or text didn't contain the domain. This updates the search to include the submitted URL in the search. It also excludes the title from the search as that can't be a real link and IIUC will not actually be actioned upon by brid.ly anyways. Note that there is no guarantee that a `selftext:` match actually contains a link however the false-positives will be filtered out when searching for links to send the webmention. Examples: - https://www.reddit.com/search?q=%22kevincox.ca%22&t=all - https://www.reddit.com/search?q=site%3A%22kevincox.ca%22&t=all - https://www.reddit.com/search?q=selftext%3A%22kevincox.ca%22&t=all - https://www.reddit.com/search?q=site%3A%22kevincox.ca%22+OR+selftext%3Akevincox.ca&t=all
|
Updated, should be good now. |
|
Looks great, thank you! |
|
This is deployed to production now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous search would not find results submitted to the site if the post title or text didn't contain the domain. This updates the search to include the submitted URL in the search. It also excludes the title from the search as that can't be a real link and IIUC will not actually be actioned upon by brid.ly anyways. Note that there is no guarantee that a
selftext:match actually contains a link however the false-positives will be filtered out when searching for links to send the webmention.Examples: