-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo account deletion (blocked on Bluesky) #1130
Comments
In an ideal world where this is solved, would this allow for blocking and unblocking from both Mastodon and Bluesky? If, say, I want to delete my bridged mastodon -> BSKY account for the time being to avoid confusion, would I later be able to follow the bridger and recreate it? Additionally, were I to delete my bridged BSKY -> Mastodon account, changed my BSKY handle, and then refollowed, would it create an account with the new BSKY handle? I know this may be blocked by that annoying AP username issue outlined in #1074 |
Blocking and unblocking to recreate the bridged account is definitely the goal! Handle changes are a separate question, you're right, #1074 tracks that. |
For what it's worth, once this here is implemented, then the handle change should be reflected in Mastodon this way, at least if you wait a few hours between actions. You'd still lose all your fediverse connections, but your follows could in theory be re-synchronised. (#1102) |
Not sure I follow, but if you mean that deleting and recreating bridged accounts like this this should give us Bluesky => fediverse handle changes for free, I don't think so. Background in #1074 (comment) . TLDR is that the actor id itself wouldn't change, and right now it's unclear how broadly the fediverse currently supports either 1) changing an actor's username while keeping its id the same or 2) deleting and recreating an actor with the same id. Both probably need some testing in the wild. |
For Mastodon specifically, I think it uses WebFinger existence to check whether to keep an account alive regarding a cleanup job. But you're right, while I don't see a uniqueness constraint on the actor id, it's definitely possible that some part of it would glitch out. |
Looks like this is already working for Bluesky => fediverse! jglypt on Bluesky blocked @ap.brid.gy at 2024-06-21T22:47:15.283184Z, and we disabled his account and sent out {
"id": "https://bsky.brid.gy/convert/ap/did:plc:4hawmtgzjx3vclfyphbhfn7v#delete-copy-activitypub-2024-06-21T22:47:15.283184+00:00",
"actor": "https://bsky.brid.gy/ap/did:plc:4hawmtgzjx3vclfyphbhfn7v",
"@context": "https://www.w3.org/ns/activitystreams",
"type": "Delete",
"object": "https://bsky.brid.gy/ap/did:plc:4hawmtgzjx3vclfyphbhfn7v",
"to": ["https://www.w3.org/ns/activitystreams#Public"]
} We weren't sure, if we |
So, fediverse => Bluesky is the remaining one here. |
...specifically, the remaining work for fediverse => Bluesky here is to figure out how to reactivate an ATProto repo that has been tombstoned: bluesky-social/atproto#2503 (reply in thread) . Related: #1119, bluesky-social/atproto#2592 . cc @lupomancer |
Hmm. I tried undelete a tombstoned repo (snarfed.org.web.brid.gy /
|
Asked @bnewbold about this ^ in https://bsky.app/profile/snarfed.org/post/3kxgh6bl6lu2j , haven't heard back yet. |
Heard back that ...except that doesn't seem to work yet. I emitted the two events below over BF's firehose just now, and got them back from the relay's firehose intact, but https://bsky.app/profile/snarfed.org.web.brid.gy still says Profile not found. https://enoki.us-east.host.bsky.network/xrpc/app.bsky.actor.getProfile?actor=did:plc:vzxheqfwpbi3lxbgdh22js66 returns 400 with the same error, as does the same call on api.bsky.app. BF hasn't received any @bnewbold any thoughts? could this be a bug in the Bluesky relay or appview or nearby? {"op": 1, "t": "#identity"}
{
"did": "did:plc:vzxheqfwpbi3lxbgdh22js66",
"seq": 1221600,
"time": "2024-07-24T17:02:27.223965+00:00",
"handle": "snarfed.org.web.brid.gy"
}
{"op": 1, "t": "#account"}
{
"did": "did:plc:vzxheqfwpbi3lxbgdh22js66",
"seq": 1221601,
"time": "2024-07-24T17:02:28.151528+00:00",
"active": true
} |
TODO for me for when this does work: https://indieweb.social/@[email protected]/112514598862207483 |
Bad news, evidently Bluesky doesn't support deleting repos after all, at least not yet: https://bsky.app/profile/bnewbold.net/post/3kzmg32tokt2r . Ah well. Maybe eventually! |
Breakthrough! bluesky-social/atproto#2806 (comment) led me to try deactivating with |
wow!! imagining we still wouldn't be able to undo the deletion if it's already been done |
Right. I'll probably be able to do it manually, eventually, but probably by creating a new bridged account, not reviving your old one. |
if you wanted to try 👉👈 |
...and change _tombstone_repo to _set_repo_status for snarfed/bridgy-fed#1130, snarfed/bridgy-fed#1119
...even if there's already a copy, since it might need to be reactivated for #1130
Shipped this, it's live! Tested with https://bsky.app/profile/snarfed.mas.to.ap.brid.gy , blocking deactivated it, and then unblocking and re-following brought it back again, including its posts. |
Started figuring out how to bring back old tombstoned Bluesky repos by recreating them as new repos. Recreating the repos works fine, but oddly I can't get them to emit the new Here's the repl code I'm using: a = ActivityPub.query(ActivityPub.handle == '...').get()
a.copies = []
a.obj.copies = []
a.put()
ATProto.create_for(a) The record gets created and stored in the repo fine, but we never emit it over our firehose. In this example, it's seq 2929703, and we emitted seq 2929703 and then seq 2929704. I suspect this is because we're not allocating sequence numbers and writing blocks in the same transaction. If we allocates a seq for the new repo's initial commit, and then another commit allocates the next seq and writes its commit, and our firehose reads it, before we write ours, our firehose will skip our commit entirely. And I'm more likely to trigger that when I do this kind of manual change locally, outside GCP, because of the network distance. Ugh. |
if you refresh, my account actually did forward a post. no avatar though, but if i try reuploading it... maybe? |
just noticed i have no display name and no bio, so it isn't the previous bug. my bad... |
Right, no display name or bio is what I mentioned in #1130 (comment) . @derspyy I'm trying something else. Could you unfollow @[email protected] and then follow again? |
yup, doing it |
It is, but Misskey incorrectly requires activity More details here: #1093 (comment) |
seems like the bridge acct isn't following me back :/ |
@derspyy sorry about that, my fault. Try again now? (And thanks for your patience!) |
(no worries! wish i knew enough about atproto to help you 😭) looks the same, though |
Thanks for trying @derspyy. Looks like this is still snarfed/arroba#34. Argh. I'll need to work on that soon. |
This is a good point, thanks for the nudge. Follows are always on bsky.brid.gy, and I think they always were - not sure - but you're right that Accepts are still on fed.brid.gy. I'll go nudge #1093 and track there. |
Right now, blocking the bridge bot account disables the bridge for you and deletes your bridged account. That's almost too easy, and right now it can't be undone, which is unfortunate. We should allow undeleting! Background in #783
The text was updated successfully, but these errors were encountered: