Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to rustls 0.20 #244

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Upgrade to rustls 0.20 #244

merged 2 commits into from
Oct 27, 2021

Conversation

dnaka91
Copy link
Contributor

@dnaka91 dnaka91 commented Oct 18, 2021 •
edited
Loading

Updating to the latest rustls 0.20 which includes some of major changes, especially how root certificates are loaded.

This is currently a draft as the rustls-native-certs version 0.6.0 is not released yet.


@dnaka91 dnaka91 mentioned this pull request Oct 18, 2021
Merged
daniel-abramov
daniel-abramov approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@daniel-abramov daniel-abramov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@djc
Copy link

djc commented Oct 26, 2021

rustls-native-certs 0.6 has been released now.

@dnaka91
Copy link
Contributor Author

dnaka91 commented Oct 26, 2021

Thanks for letting me know. I'll update the PR soon.

@daniel-abramov
Copy link
Member

Thanks for the update, guys! 🚀

Ok, it seems like the PR could be set to be ready for review (and probably even merged, from what I can see it looks complete), right?

@dnaka91 dnaka91 marked this pull request as ready for review October 27, 2021 11:55
@dnaka91
Copy link
Contributor Author

dnaka91 commented Oct 27, 2021

Sorry, forgot to switch this from a draft to a proper PR. Done now 🚀

@daniel-abramov daniel-abramov merged commit 4729b0f into snapview:master Oct 27, 2021
@dnaka91 dnaka91 deleted the rustls-0.20 branch October 27, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-abramov daniel-abramov daniel-abramov approved these changes

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnaka91 @djc @daniel-abramov