Fix ws request subportocol lowercase header #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kids300
changed the title
daniel-abramov
approved these changes
May 19, 2020
There was a problem hiding this comment.
I'm not against these changes (although I have not heard any server rejecting the connection because of this), but I think we may move them into a function and write a comment about that. @agalakhov , what do you think?
|
@agalakhov , since there were no objections, I'll merge this PR, it does not seem like it can break something, but instead allow more servers to work well with tungstenite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC6445 Sec11.3 specifies several headers like
Sec-WebSocket-Protocol. While it does not specifies the key should be case insensitive, many server only accepts case sensitive requests. However http case every key to lowercase for convince. hyper has an issue to solve this problem (hyperium/hyper#1492), but not in http. This is a workaround to make the websocket server happy.