Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show "clear delegations" button only when there is existing delegations #4942

Merged

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Dec 1, 2024

Summary

This PR fix an issue where the "clear delegations" button in the split delegation modal was always appearing (it should be hidden when there are no existing delegations)

How to test

  1. Go to http://localhost:8081/#/test.wa0x6e.eth/delegates?delegate=
  2. The "clear delegation" link should not appear if you don't have any existing delegations
  3. Login as 0x674a5A935c8A23EEA552478E5Dfc65f88a357665 using impersonator
  4. Go to http://localhost:8081/#/paraswap-dao.eth/delegates?delegate=
  5. There should be existing delegations, and the clear delegations button should appear

@wa0x6e wa0x6e requested a review from ChaituVR December 1, 2024 11:13
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit 8d71296 into master Dec 2, 2024
7 checks passed
@wa0x6e wa0x6e deleted the fix-clear-delegation-button-not-hidding-when-irrelevant branch December 2, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants