Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Domains list to allow iframe on all subdomains #4900

Merged
merged 1 commit into from
Sep 30, 2024
Merged

feat: Domains list to allow iframe on all subdomains #4900

merged 1 commit into from
Sep 30, 2024

Conversation

ChaituVR
Copy link
Member

Summary

Allow *.blockscout.com to show snapshot in iframes

Context https://discord.com/channels/955773041898573854/1125390177888645231/1290249564623736885

How to test

  1. Go to https://eth.blockscout.com/apps/zerion, or https://optimism.blockscout.com/apps/zerion open console and edit HTML, replace with
<body>
    <iframe src="http://localhost:8080/#/"></iframe>
</body>
  1. Previously it should not allow
  2. Now it should allow on all subdomains
  3. It should allow snapshot on any other domains

@ChaituVR ChaituVR self-assigned this Sep 30, 2024
wa0x6e
wa0x6e approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit c17e254 into master Sep 30, 2024
6 checks passed
@ChaituVR ChaituVR deleted the domains-list-to-allow-all-subdomains branch September 30, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e approved these changes

@bonustrack bonustrack Awaiting requested review from bonustrack

Assignees

@ChaituVR ChaituVR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e