Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix stamp avatar case sensitiveness #4893

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: fix stamp avatar case sensitiveness #4893

merged 1 commit into from
Sep 30, 2024

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Sep 29, 2024

Summary

This PR fix an issue where the UserAvatar component was case sensitive, this considering 2 exact same addres, but with different case as different.

This PR will always checksummed the address

How to test

  1. Go to http://localhost:8080/#/cowtesting.eth/delegates
  2. Console inspect a random delegate with avatar
  3. This avatar should have a timestamp params, and address is checksummed
  4. Click on the card to go to delegate statement
  5. The avatar in the sidebar should load immediately (since loaded from cache)
  6. This avatar should have same same exact url as before (checksummed, and same timestamp params)

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit 4a52af5 into master Sep 30, 2024
5 checks passed
@wa0x6e wa0x6e deleted the fix-avatar-cache branch September 30, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants