Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Networks page doesn't work in dev mode #4884

Merged
merged 5 commits into from
Sep 30, 2024
Merged

fix: Networks page doesn't work in dev mode #4884

merged 5 commits into from
Sep 30, 2024

Conversation

ChaituVR
Copy link
Member

Summary

  • network route now redirects to v2 network page

How to test:

  • Go to https://snapshot.org/#/?filter=networks it throws in console and Add network button will be hidden
    image
  • In dev mode, it will not load the entire page
  • After fix you should see the page and button

@ChaituVR ChaituVR requested a review from wa0x6e September 20, 2024 08:11
@ChaituVR ChaituVR requested review from wa0x6e and removed request for wa0x6e September 30, 2024 08:05
wa0x6e
wa0x6e requested changes Sep 30, 2024
View reviewed changes
src/views/ExploreView.vue Outdated Show resolved Hide resolved
wa0x6e
wa0x6e reviewed Sep 30, 2024
View reviewed changes
src/views/ExploreView.vue Outdated Show resolved Hide resolved
wa0x6e
wa0x6e requested changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@wa0x6e wa0x6e merged commit 43875b2 into master Sep 30, 2024
4 of 6 checks passed
@wa0x6e wa0x6e deleted the fix-networks-page branch September 30, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e