Release 0.1.6 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anisetti-Jayathi-ML
requested review from
Deepa-Martin-ML and
Muthukrisna-PT-ML
Muthukrisna-PT-ML
approved these changes
Apr 23, 2024
Deepa-Martin-ML
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Getting this error in logs when tracing enabled for odoo16 application
end_transaction(elasticapm, client, request, response) # add before return response
File "/home/isha/isha/sushumna_16/venv/lib/python3.7/site-packages/sf_apm_lib/snappyflow.py", line 136, in end_transaction
val = request.params.get(key)
AttributeError: 'Request' object has no attribute 'params'
Root cause: As there is code to handle "if there is no params attribute in request attribute" case in end_transaction()
we are getting this error.
Changes made : Added code in snappyflow.py end_transaction() to handle if there is no params attribute in request attribute case.
Testcases executed:
Added changes locally
previously we are getting this error
And after making changes its running without any errors
And getting traces successfully