feat: Misc fixes #198
Merged
feat: Misc fixes #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amhn
force-pushed
the
misc_fixes
branch
2 times, most recently
from
2444a3d to
64d1428
Compare
|
Hello @amhn. Thanks for this PR. There is a folder called |
|
That was a typo / wrong git mv call. I pushed a new verstion that fixes this. |
|
OK for me. I will just review the commit msg to have a pretty changelog. |
|
Feel free to change them as needed. You should be able to push into my branch. |
fixes: smutel#192 - cluster_id is optional - site_id added - One of cluster_id, site_id must be provided - device_id added
Fixes: 180 - Fix field default. - Add group_name and ui_visibility to customfield
Fixes: 194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #180
Fixes: #187
Fixes: #188
Fixes: #189
Fixes: #190
Fixes: #191
Fixes: #192
Fixes: #193
Fixes: #194
Fixes: #195
Fixes: #196
Fixes: #197
This fixes the above issues. One issue per commit. After every commit, all tests pass.