-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple .NET versions in the NuGet package #94
Comments
Please download v4.0 of MvcMailer. It's possible to supply separate binaries for target versions, but the code gets a bit messy with dupes. Hope this helps. On Mon, Apr 8, 2013 at 12:25 PM, John Rummell [email protected]
|
Hi @smsohan I've just been looking at the differences between version 4.5 and 4.0, and the changes to MvcMailMessage.SendAsync can be achieved without upgrading to .NET 4.5 and using async. If you're happy to take it I'll send a pull request with the change and with the project downgraded to .NET 4 again. |
We gave it a shot and encountered issues, hence the upgrade. Either way, Sohan On Thu, Jun 20, 2013 at 2:25 PM, James Skimming [email protected]:
|
What issues did you encounter, I've just sent pull request #99 which is quite simple, so I'm concerned if i've missed something, all the tests still pass. |
The latest version of MvcMailer is compiled under .NET 4.5, so it can't be added to .NET 4.0 projects. It is possible to include framework specific versions of a library in a single package. See http://docs.nuget.org/docs/creating-packages/creating-and-publishing-a-package#Supporting_Multiple_.NET_Framework_Versions_and_Profiles
Another option would be to create a separate MvcMailer4 package for .NET 4.0. I had to install the 4.0 version of MvcMailer from the command line in my .NET 4.0 project.
The text was updated successfully, but these errors were encountered: