-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change prefix format and pass New Relic sink #1
fix: change prefix format and pass New Relic sink #1
Conversation
… new recorder instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one thing. You can't leave the NewRelicSink there since tests will try to send metrics over it. We should find the way to, in tests, just print metrics out over stdout or discard them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one thing. You can't leave the NewRelicSink there since tests will try to send metrics over it. We should find the way to, in tests, just print metrics out over stdout or discard them.
Should we then go back to the |
Yes, I do. BTW, any idea on how to make that possible? |
I guess we could print a brief message over stdout with the metrics sent, just to test we are actually sending them regardless the sink we're using. And then only running the tests containing all the information about the metrics when executing the tests for an specific sink like New Relic. Does it make sense for you? |
Ok, I see you've already solved it here 👍 |
c9027b5
to
e9e79f6
Compare
Closing in favor of #2 |
Change prefix format for metric name and pass New Relic specific sink when creating a new recorder instance.
Relates to asyncapi#841