-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add method for 'action.invoked' new metric to be implemented #15
Conversation
@smoya Do you like |
Not strong reason to choose one or another. However, maybe it makes sense to call it |
test/recorder.spec.ts
Outdated
it('recordActionInvoke()', async function() { | ||
const recorderMetricsSpy = []; | ||
const recorder = new Recorder('test', new testSink(), recorderMetricsSpy); | ||
const expectedMetric = new Metric('test.action.invoked', MetricType.Counter, 1, { action: 'convert', success: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding success
here might sound confusing, since you don't really have the data because the action didn't finished yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, makes sense 👍
Agree! I think that's the appropriate naming to avoid typos and possible errors 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀🌔
@peter-rr I changed the conventional commit prefix to include |
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Just adding
recordActionInvoke()
method and its corresponding test.This method will be called by the different CLI commands at the time they are invoked in order to send a new metric called
asyncapi_adoption.action.invoked
.Relates to:
asyncapi/cli#841